[ovs-dev] [PATCH 2/8] vswitchd: Limit number of ports to 65335.

Ethan Jackson ethan at nicira.com
Mon Jan 31 04:14:07 UTC 2011


I agree that we should eventually move to 32bit port numbers.
However, I think until we make the move consistently throughout the
code base it's better to have bridge.c reflect what is actually
supported.  Most notably I'm worried about how the bridge interacts
with mac_learning.  I haven't done a deep inspection of that code, but
mac_learning_learn takes uint16_t port numbers.

LACP only allocates 16bits for each "aggregator key" (one per port in
ovs case).  So we can have at most 2^16 LACP enabled bonds.  I use
port_idx as the identifier in the future patches, but I'm fine with
dropping this patch and generating our own uint16_t id number for LACP
ports if you think that's preferable.

On Sun, Jan 30, 2011 at 7:54 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Sun, Jan 30, 2011 at 3:56 PM, Ethan Jackson <ethan at nicira.com> wrote:
>> This commit limits the number of ports in a bridge to UINT16_MAX.
>> This will allow future commits to use a port's port_idx as a
>> convenient ID number.
>
> Without looking at the patch itself, I'm worried that this is moving in
> the wrong direction.  Both OpenFlow 1.1 and the Open vSwitch datapath are
> moving to 32-bit port numbers, so the trend outside the bridge code is
> the opposite tack that this patch is taking.
>
> Comments?
>




More information about the dev mailing list