[ovs-dev] [PATCH] lib: netdev-vport improperly initialized route-table.

[Justin Pettit]

Looks good to me.

--Justin


On Jan 31, 2011, at 12:06 PM, Ethan Jackson wrote:

> netdev-vport unregistered the routing table in its destroy
> function, but registered it in its init function.  This could
> cause the routing table to be unregistered when it shouldn't have
> been causing segmentation faults.
> 
> Bug #4526.
> ---
> lib/netdev-vport.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
> index 436be8c..4da44da 100644
> --- a/lib/netdev-vport.c
> +++ b/lib/netdev-vport.c
> @@ -193,7 +193,6 @@ static int
> netdev_vport_init(void)
> {
>     netdev_vport_tnl_iface_init();
> -    route_table_register();
>     return 0;
> }
> 
> @@ -253,6 +252,7 @@ netdev_vport_create(const struct netdev_class *netdev_class, const char *name,
>         dev->options = options;
> 
>         *netdev_devp = &dev->netdev_dev;
> +        route_table_register();
>     } else {
>         ofpbuf_delete(options);
>     }
> -- 
> 1.7.2
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org