[ovs-dev] [PATCH] ovsdb-tool: Put version number in comment when compacting or converting.

[Justin Pettit]

Looks good to me.

--Justin


On Jul 7, 2011, at 12:25 PM, Ben Pfaff wrote:

> Adding the version number can make it clear what version of OVS screwed
> something up as part of an upgrade or downgrade.
> ---
> ovsdb/ovsdb-tool.c |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c
> index 07d2729..822eb6b 100644
> --- a/ovsdb/ovsdb-tool.c
> +++ b/ovsdb/ovsdb-tool.c
> @@ -228,7 +228,8 @@ compact_or_convert(const char *src_name, const char *dst_name,
> static void
> do_compact(int argc OVS_UNUSED, char *argv[])
> {
> -    compact_or_convert(argv[1], argv[2], NULL, "compacted by ovsdb-tool");
> +    compact_or_convert(argv[1], argv[2], NULL,
> +                       "compacted by ovsdb-tool "VERSION BUILDNR);
> }
> 
> static void
> @@ -239,7 +240,7 @@ do_convert(int argc OVS_UNUSED, char *argv[])
> 
>     check_ovsdb_error(ovsdb_schema_from_file(schema_file_name, &new_schema));
>     compact_or_convert(argv[1], argv[3], new_schema,
> -                       "converted by ovsdb-tool");
> +                       "converted by ovsdb-tool "VERSION BUILDNR);
>     ovsdb_schema_destroy(new_schema);
> }
> 
> -- 
> 1.7.4.4
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev