[ovs-dev] [nic-401] ofproto-dpif: Do not mirror L2 multicast switch protocols to VLANs.

[Andrew Evans]

On Mon, Jul 11, 2011 at 3:37 PM, Ben Pfaff <blp at nicira.com> wrote:

I'm not familiar enough with the issue to say whether the patch is
correct or not, but I did notice what appears to be a truncated
comment:

> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> index 7264355..5b663e1 100644
> --- a/ofproto/ofproto-dpif.c
> +++ b/ofproto/ofproto-dpif.c
> @@ -3360,6 +3360,45 @@ vlan_is_mirrored(const struct ofmirror *m, int vlan)
>     return vlan_bitmap_contains(m->vlans, vlan);
>  }
>
> +/* Returns true if a packet with Ethernet destination MAC 'dst' may be mirrored
> + * to a VLAN.  In general most packets may be mirrored but we want to drop
> + * protocols that  */

Did you intend to write something more here?