[ovs-dev] [PATCH] configure: Improve error message when pkg-config is missing.
Ethan Jackson
ethan at nicira.com
Wed Jul 13 18:02:47 UTC 2011
Looks good to me.
Ethan
On Wed, Jul 13, 2011 at 10:59, Ben Pfaff <blp at nicira.com> wrote:
> Until now, when pkg-config is missing, Autoconf emitted this error:
> error: possibly undefined macro: PKG_CHECK_MODULES
> This commit changes the message to:
> error: Please install pkg-config.
> This should be easier for users to interpret.
>
> Suggested-by: Ethan Jackson <ethan at nicira.com>
> ---
> m4/openvswitch.m4 | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4
> index 73db4bb..e9edc49 100644
> --- a/m4/openvswitch.m4
> +++ b/m4/openvswitch.m4
> @@ -92,8 +92,7 @@ AC_DEFUN([OVS_CHECK_OPENSSL],
> [ssl=check])
>
> if test "$ssl" != false; then
> - dnl Make sure that pkg-config is installed.
> - m4_pattern_forbid([PKG_CHECK_MODULES])
> + m4_ifndef([PKG_CHECK_MODULES], [m4_fatal([Please install pkg-config.])])
> PKG_CHECK_MODULES([SSL], [openssl],
> [HAVE_OPENSSL=yes],
> [HAVE_OPENSSL=no
> --
> 1.7.4.4
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
More information about the dev
mailing list