[ovs-dev] [PATCH] [patch v2] ofproto-dpif: Allow setting of flow eviction threshold

Ben Pfaff blp at nicira.com
Thu Jul 28 16:16:49 UTC 2011


On Thu, Jul 28, 2011 at 08:07:18PM +0900, Simon Horman wrote:
> Allow setting the number of flows present in the flow hash
> at which point eviction of entries from the kernel flow hash
> will begin to occur.
> 
> The value may be set using a bridge's other-config column.
> 
> e.g.
> 
> ovs-vsctl set bridge br3 other-config:flow-eviction-threshold=10000
> 
> default is 1000, reflecting constant value previously used.
> 
> Increasing this value can result in reduced CPU usage and
> packet loss in situations where the number of active flows
> is significantly larger than 1000.
> 
> ---
> 
> v2
> As suggested by Ben Pfaff
> * Ensure that the flow_eviction_threshold element of struct ofproto
>   is always initialised by calling ofproto_set_flow_eviction_threshold()
>   from ofproto_create()
> * Limit the minimum value for threshold to 100
> * Note that the flow_eviction_threshold element of struct ofproto
>   only affects the ofproto-dpif implementation.
> * Flesh out description in vswitch.xml to include motivation and,
>   minimum and default values.

This version is almost there.  I only have nits to pick:

	* In OVS userspace we always put {} around the statements
          inside "if".

	* In vswitch.xml please end sentences with a period.

And then I'll apply it.

Thank you!



More information about the dev mailing list