[ovs-dev] [async 5/6] ofproto: Collect all rules for an OpenFlow request before acting on any.

Ethan Jackson ethan at nicira.com
Wed Jun 1 20:11:39 UTC 2011


collect_rules_loose() and collect_rules_strict() pass a uint16_t
out_port into rule_has_out_port() which expects a ovs_be16.

> +    error = collect_rules_loose(p, fm->table_id, &fm->cr, fm->out_port,
> +                                &rules);
> +    return (error ? error
> +            : !list_is_empty(&rules) ? delete_flows__(&rules)
> +            : 0);
>  }

The check for list_is_empty() here seems redundant to me.  I suppose
it's fine as documentation though.

Ethan



More information about the dev mailing list