[ovs-dev] [PATCH] dpif-linux: Avoid duplicate code in dpif_linux_vport_send().

Ben Pfaff blp at nicira.com
Mon Jun 6 16:56:59 UTC 2011


On Fri, Jun 03, 2011 at 05:25:14PM -0700, Ethan Jackson wrote:
> dpif_linux_vport_send() had duplicated most of the code in
> dpif_linux_execute() in order to execute output actions in the
> kernel.  This forces developers to remember to change both
> functions whenever the kernel interface changes.  In particular,
> commit 80e5eed9 "datapath: Get packet metadata from userspace in
> odp_packet_cmd_execute()." broke netdev_linux_vport_send().  This
> commit reorganizes the code and fixes the regression.
> 
> Bug #5818.

Looks good, thank you!



More information about the dev mailing list