[ovs-dev] [PATCH] ofproto-dpif: xlate_actions() more judiciously.

Jean Tourrilhes jt at hpl.hp.com
Tue Jun 7 18:25:53 UTC 2011


On Tue, Jun 07, 2011 at 09:25:49AM -0700, Ben Pfaff wrote:
> On Mon, Jun 06, 2011 at 06:20:02PM -0700, Jean Tourrilhes wrote:
> > 	Just for curiosity, I've implemented the patch along the line
> > of Ben suggestions, see below. I'm wondering if the compiler is smart
> > enough to pack bools, if not, I may use bitfields...
> 
> Adding a "bool" there should not increase the size of the structure
> since there is already some padding.
> 
> Bit-fields usually make code slower since the compiler isn't very good
> at optimizing access to them.
> 
> Your patch looks good to me.  Ethan, would you mind taking a look too,
> since you've been thinking about this?  If it looks good to you then
> I'll commit it to master.

	Second version with the bitfield, just because ;-)
	Regards,

	Jean
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ovs-1.1.0-hpl-resubmit-stats-2.diff
Type: text/x-diff
Size: 3459 bytes
Desc: not available
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20110607/e788730f/attachment-0003.bin>


More information about the dev mailing list