[ovs-dev] [leaks 5/5] list: Clarify description of list_moved().

Ben Pfaff blp at nicira.com
Tue Jun 7 23:33:19 UTC 2011


Thank you.  I pushed this series to "master".

On Tue, Jun 07, 2011 at 04:28:50PM -0700, Ethan Jackson wrote:
> Looks Good.
> 
> Ethan
> 
> On Tue, Jun 7, 2011 at 13:22, Ben Pfaff <blp at nicira.com> wrote:
> > This function doesn't have any users, but an upcoming commit will add one.
> > ---
> > ?lib/list.c | ? ?6 +++++-
> > ?1 files changed, 5 insertions(+), 1 deletions(-)
> >
> > diff --git a/lib/list.c b/lib/list.c
> > index b5fa389..a236f8c 100644
> > --- a/lib/list.c
> > +++ b/lib/list.c
> > @@ -90,7 +90,11 @@ list_replace(struct list *element, const struct list *position)
> > ?}
> >
> > ?/* Adjusts pointers around 'list' to compensate for 'list' having been moved
> > - * around in memory (e.g. as a consequence of realloc()). */
> > + * around in memory (e.g. as a consequence of realloc()).
> > + *
> > + * This always works if 'list' is a member of a list, or if 'list' is the head
> > + * of a non-empty list. ?It fails badly, however, if 'list' is the head of an
> > + * empty list; just use list_init() in that case. */
> > ?void
> > ?list_moved(struct list *list)
> > ?{
> > --
> > 1.7.4.4
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >



More information about the dev mailing list