[ovs-dev] [brcompatd 8/8] ovs-brcompatd: Run ovs-vsctl instead of accessing database directly.

Jesse Gross jesse at nicira.com
Wed Jun 8 21:04:11 UTC 2011


On Wed, Jun 8, 2011 at 1:47 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Jun 08, 2011 at 01:05:45PM -0700, Jesse Gross wrote:
>> On Mon, Jun 6, 2011 at 12:41 PM, Ben Pfaff <blp at nicira.com> wrote:
>> > ovs-vsctl is carefully written to avoid races in database access. ??It is
>> > much simpler to just call it than to reimplement its capabilities.
>> >
>> > This eliminates the requirement that bridges managed by ovs-brcompatd have
>> > no ports at ovs-brcompatd startup time. ??It also eliminates races between
>> > competing brctl and ovs-vsctl processes.
>>
>> There are some new warnings after this patch (that look real):
>> vswitchd/ovs-brcompatd.c:522: warning: 'br_vlan' is used uninitialized
>> in this function
>> vswitchd/ovs-brcompatd.c:522: warning: 'br_vlan' is used uninitialized
>> in this function
>
> You're right.  How's this look?  Does it fix the warning for you?  (My
> GCC doesn't warn either way.)

Looks reasonable to me and fixes the problem, thanks.



More information about the dev mailing list