[ovs-dev] [initscripts 4/5] xenserver: Don't delete pidfile in stop_daemon.

Ben Pfaff blp at nicira.com
Wed Jun 15 23:41:59 UTC 2011


Deleting the pidfile introduces a minor race: if some other process is
starting a daemon at the same time that the init script is stopping the
same daemon, then this could delete the new daemon's pidfile.

This is really a theoretical risk, because no one should be starting and
stopping a single daemon at the same time.
---
 xenserver/etc_init.d_openvswitch |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/xenserver/etc_init.d_openvswitch b/xenserver/etc_init.d_openvswitch
index 6917fba..9d5577e 100755
--- a/xenserver/etc_init.d_openvswitch
+++ b/xenserver/etc_init.d_openvswitch
@@ -262,7 +262,6 @@ function stop_daemon {
                 break
             fi
         done
-        rm -f "$pidfile"
     fi
 }
 
-- 
1.7.4.4




More information about the dev mailing list