[ovs-dev] [PATCH 3/5] tunneling: Avoid extra copying if expanding headroom.

[Jesse Gross]

On Thu, Jun 16, 2011 at 1:13 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Jun 15, 2011 at 11:00:07AM -0700, Jesse Gross wrote:
>> Currently if we need additional headroom before encapsulating a
>> packet a clone is made before expanding headroom or if we are
>> just trying to make the headroom writable then we copy both
>> the struct sk_buff and the paged data.  Both of these are unnecessary
>> and we end up freeing the original copy.  We can remove these copies
>> and simplify the code by just expanding the linear data area.
>>
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>
> Acked-by: Ben Pfaff <blp at nicira.com>
>
> The max_t expression is almost unreadable.  A temporary variable would
> help.

Changed.