[ovs-dev] [PATCH 2/2] bridge: Avoid duplicate logging when netdev_get_etheraddr() fails.
Ben Pfaff
blp at nicira.com
Thu Jun 16 21:05:40 UTC 2011
get_etheraddr() in netdev-linux.c logs when the Ethernet address cannot be
obtained so there is no need to log again in the caller.
Bug #5844.
---
vswitchd/bridge.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 9868ef5..3a9cfa9 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -1023,9 +1023,6 @@ bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
/* Grab MAC. */
error = netdev_get_etheraddr(iface->netdev, iface_ea);
if (error) {
- static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
- VLOG_ERR_RL(&rl, "failed to obtain Ethernet address of %s: %s",
- iface->name, strerror(error));
continue;
}
}
--
1.7.4.4
More information about the dev
mailing list