[ovs-dev] [PATCH 5/5] datapath: Further mirror checksum offloading state on old kernels.

[Ben Pfaff]

On Thu, Jun 16, 2011 at 02:17:07PM -0700, Jesse Gross wrote:
> On Thu, Jun 16, 2011 at 1:38 PM, Ben Pfaff <blp at nicira.com> wrote:
> > I think that it would help my understanding if compute_ip_summed() and
> > forward_ip_summed() had comments that explained why one would call
> > them and what they do. ??compute_ip_summed() does have a large comment
> > already, but it explains only the details, not the "big picture"
> > rationale behind what it does.
> 
> I added the following comments:
[...]
> Does that help?

Yes, a great deal.  I didn't even realize before that these were
paired for ingress into OVS and egress out of OVS, although in
hindsight I should have.

I think that the "(see below)" in the comment inside
compute_ip_summed() should now say "(see
switch_skb_checksum_setup())".

Acked-by: Ben Pfaff <blp at nicira.com>