[ovs-dev] [PATCH] netdev-vport: Don't use ipsec options for either arg in config_equal_ipsec().

Ben Pfaff blp at nicira.com
Fri Jun 17 01:20:28 UTC 2011


On Thu, Jun 16, 2011 at 06:14:21PM -0700, Justin Pettit wrote:
> Commit aebf423 (netdev: Add methods to do netdev-specific argument
> comparisons.) added a new config_equal_ipsec() function to ignore
> IPsec key options when comparing an existing netdev's options with a new
> netdev.  We only ignored the options for the new netdev configuration,
> which works when pulling the existing configuration from the kernel.
> Unfortunately, if this is just a re-init of a netdev for which we just
> created, this ignoring of the IPsec key options on the new netdev will
> cause the check to fail, since the full options actually available in
> both netdevs.  This commit just ignore all IPsec key options from both
> netdevs.

Wow, that's really brute-force.  But it looks like it will work.  We can
clean it up later.



More information about the dev mailing list