[ovs-dev] [PATCH 3/3] xenserver: New iface-status external id.

[Ethan Jackson]

Cool, i'll go ahead and merge.

Thanks for the reviews.

Ethan

On Fri, Jun 17, 2011 at 11:47, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Jun 17, 2011 at 11:33:33AM -0700, Ethan Jackson wrote:
>> > I think that update_iface() will now always call into ovs-vsctl to set
>> > the iface-status. ?I think that it should only do it if it needs to
>> > change, as we do for iface-id.
>>
>> update_iface() is only called on a given interface when there is a
>> change in it's xs-vif-uuid, iface-id, or iface-status.  It isn't
>> called every time we go through the poll loop, or every time the
>> database changes in some way.  I don't think it's a big deal that we
>> do a redundant write to that table when the xs-vif-uuid changes but
>> the iface-status doesn't need to.  I may be wrong though, does this
>> sound reasonable?
>
> It sounds fine given that explanation.  Thanks.
>