[ovs-dev] [PATCH] bridge: Populate interface status/statistics as soon as a port is added.

Ben Pfaff blp at nicira.com
Tue Jun 28 20:13:57 UTC 2011


On Tue, Jun 28, 2011 at 01:10:49PM -0700, Andrew Evans wrote:
> On Tue, 2011-06-28 at 13:05 -0700, Andrew Evans wrote:
> > On Tue, 2011-06-28 at 12:53 -0700, Ben Pfaff wrote:
> > > On Tue, Jun 28, 2011 at 12:49:37PM -0700, Andrew Evans wrote:
> > > > On Tue, 2011-06-28 at 09:05 -0700, Ben Pfaff wrote:
> > > > > On Mon, Jun 27, 2011 at 06:57:31PM -0700, Andrew Evans wrote:
> > > > > > Currently there's a lag of up to five seconds before the status and statistics
> > > > > > columns in the Interface table are populated when a port is first added to a
> > > > > > bridge. This may confuse systems that expect those columns to be populated
> > > > > > right away.
> > > > > > 
> > > > > > Bug #5820.
> > > > > 
> > > > > Do you think that we could do this just in the case where we added a
> > > > > new port?
> > > > 
> > > > Ok. I had to resort to checking the mtu column in the Interface row to
> > > > reliably determine when we need to do this. The patch now looks like:
> > > 
> > > Isn't a test like "if (!iface->cfg->n_ofport)" adequate?
> > 
> > Yes, except in the case where the Interface row is deleted and re-added
> > in the same transaction. I'm trying to cover that case as well.
> 
> Here's a simpler patch:

Looks good, thank you.



More information about the dev mailing list