[ovs-dev] [PATCH 1/2] ovs-ctl: Fix ovs-dpctl invocation.

Ben Pfaff blp at nicira.com
Wed Jun 29 23:00:37 UTC 2011


We call them all directly now.  Anyone who wants to use a different
one can always add a directory early in $PATH.

On Wed, Jun 29, 2011 at 03:57:29PM -0700, Ethan Jackson wrote:
> Looks fine to me.  Are we calling all of the ovs utilities directly
> instead of through variables?  If not, perhaps we should define a
> $dpctl variable instead?
> 
> Ethan
> 
> On Wed, Jun 29, 2011 at 15:55, Ben Pfaff <blp at nicira.com> wrote:
> > There's no $dpctl variable so this always failed.
> > ---
> > ?utilities/ovs-ctl.in | ? ?2 +-
> > ?1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in
> > index 6b0337f..a149905 100755
> > --- a/utilities/ovs-ctl.in
> > +++ b/utilities/ovs-ctl.in
> > @@ -244,7 +244,7 @@ force_reload_kmod () {
> > ? ? chmod +x "$script"
> >
> > ? ? for dp in `ovs-dpctl dump-dps`; do
> > - ? ? ? ?action "Removing datapath: $dp" "$dpctl" del-dp "$dp"
> > + ? ? ? ?action "Removing datapath: $dp" ovs-dpctl del-dp "$dp"
> > ? ? done
> >
> > ? ? if test -e /sys/module/openvswitch_mod; then
> > --
> > 1.7.4.4
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >



More information about the dev mailing list