[ovs-dev] [actions 4/5] ofp-util: Centralize decoding of OpenFlow actions.

Andrew Evans aevans at nicira.com
Wed Jun 29 23:56:33 UTC 2011


On Fri, 2011-06-24 at 15:02 -0700, Ben Pfaff wrote:
> +    case OFPUTIL_OFPAT_OUTPUT:
> +        port = ntohs(a->output.port);
>          if (port < OFPP_MAX) {
> -            ds_put_format(string, "output:%"PRIu16, port);
> +            ds_put_format(s, "output:%u", port);

Is there some reason you changed this from one of the PRI.. macros to a
format string literal, yet in other places you preserved the usage of
the PRI.. macros?

Looks good to me otherwise, thanks.





More information about the dev mailing list