[ovs-dev] [PATCH] datapath: Drop BUG_ON when checksumming and copying.

Ben Pfaff blp at nicira.com
Thu Mar 3 22:55:23 UTC 2011


On Thu, Mar 03, 2011 at 02:00:52PM -0800, Jesse Gross wrote:
> Normally when performing checksum offloading the transport header
> must be present in the linear data area.  However, this might not
> be the case with packets processed by GRO.  On transmit these
> packets are processed by GSO if emulation of checksum offloading
> needs to be performed.  Unlike skb_checksum_help(), the GSO code
> does not have any requirements about the packet structure.  Since
> our code that copies and checksums packets to userspace is called
> in conditions similar to GSO and does not have any assumptions
> about layout, drop the BUG_ON assertion.
> 
> NIC-343
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list