[ovs-dev] [PATCH 2/2] netdev-vport: Log at ERR level when port won't be created.
Justin Pettit
jpettit at nicira.com
Mon Mar 14 20:47:16 UTC 2011
Suggested-by: Ben Pfaff <blp at nicira.com>
---
lib/netdev-vport.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
index 8715109..09909df 100644
--- a/lib/netdev-vport.c
+++ b/lib/netdev-vport.c
@@ -695,7 +695,7 @@ parse_tunnel_config(const char *name, const char *type,
*/
use_ssl_cert = shash_find_data(args, "use_ssl_cert");
if (!use_ssl_cert || strcmp(use_ssl_cert, "true")) {
- VLOG_WARN("%s: 'peer_cert' requires 'certificate' argument",
+ VLOG_ERR("%s: 'peer_cert' requires 'certificate' argument",
name);
return EINVAL;
}
@@ -723,18 +723,18 @@ parse_tunnel_config(const char *name, const char *type,
pid_t pid = read_pidfile(file_name);
free(file_name);
if (pid < 0) {
- VLOG_WARN("%s: IPsec requires the ovs-monitor-ipsec daemon",
+ VLOG_ERR("%s: IPsec requires the ovs-monitor-ipsec daemon",
name);
return EINVAL;
}
if (shash_find(args, "peer_cert") && shash_find(args, "psk")) {
- VLOG_WARN("%s: cannot define both 'peer_cert' and 'psk'", name);
+ VLOG_ERR("%s: cannot define both 'peer_cert' and 'psk'", name);
return EINVAL;
}
if (!ipsec_mech_set) {
- VLOG_WARN("%s: IPsec requires an 'peer_cert' or psk' argument",
+ VLOG_ERR("%s: IPsec requires an 'peer_cert' or psk' argument",
name);
return EINVAL;
}
@@ -746,7 +746,7 @@ parse_tunnel_config(const char *name, const char *type,
}
if (!daddr) {
- VLOG_WARN("%s: %s type requires valid 'remote_ip' argument",
+ VLOG_ERR("%s: %s type requires valid 'remote_ip' argument",
name, type);
return EINVAL;
}
@@ -870,22 +870,22 @@ parse_patch_config(const char *name, const char *type OVS_UNUSED,
peer = shash_find_data(args, "peer");
if (!peer) {
- VLOG_WARN("%s: patch type requires valid 'peer' argument", name);
+ VLOG_ERR("%s: patch type requires valid 'peer' argument", name);
return EINVAL;
}
if (shash_count(args) > 1) {
- VLOG_WARN("%s: patch type takes only a 'peer' argument", name);
+ VLOG_ERR("%s: patch type takes only a 'peer' argument", name);
return EINVAL;
}
if (strlen(peer) >= IFNAMSIZ) {
- VLOG_WARN("%s: patch 'peer' arg too long", name);
+ VLOG_ERR("%s: patch 'peer' arg too long", name);
return EINVAL;
}
if (!strcmp(name, peer)) {
- VLOG_WARN("%s: patch peer must not be self", name);
+ VLOG_ERR("%s: patch peer must not be self", name);
return EINVAL;
}
--
1.7.1
More information about the dev
mailing list