[ovs-dev] [PATCH] vswitchd: Dump QoS with appctl.

[Ben Pfaff]

On Mon, Mar 14, 2011 at 04:49:26PM -0700, Ethan Jackson wrote:
> The source of truth for QoS statistics on a given interface is tc.
> Unfortunately, output from tc can be a little bit confusing and
> does not follow the same data model as OVS.  This commit adds a
> "qos/show" appctl command which gives friendlier output.

Thanks for the update.

I see that you put the error messages that I asked for into the log,
with VLOG_WARN.  I actually intended that they should go directly into
the output, e.g.:
        ds_put_format(ds, "Failed to get statistics for queue %u: %s\n",
                      queue_id, strerror(error));
and
            ds_put_format(&ds, "failed to dump queues: %s\n", strerror(error));
That way the admin doesn't have to look at the log separately (or to
guess that he might need to).

Otherwise looks good.  Thank you, please push this out when you are
satisfied with it.