[ovs-dev] [PATCH 2/2] hfsc: min-rate tweaks.

Ethan Jackson ethan at nicira.com
Tue Mar 15 19:31:32 UTC 2011


A min-rate doesn't make sense on the parent qdisc.  Setting it to
one seems a bit clearer and will hopefully give the kernel a little
bit more flexibility.

There doesn't appear to be any reason to enforce a minimum min-rate
of 1500Bps on queues. This commit lowers the minimum to 1Bps.  A
min-rate of 0 is not allowed by hfsc in the kernel.
---
 lib/netdev-linux.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index baaa1e6..68410de 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -2955,7 +2955,7 @@ hfsc_parse_qdisc_details__(struct netdev *netdev, const struct shash *details,
         max_rate = netdev_features_to_bps(current) / 8;
     }
 
-    class->min_rate = max_rate;
+    class->min_rate = 1;
     class->max_rate = max_rate;
 }
 
@@ -2973,7 +2973,7 @@ hfsc_parse_class_details__(struct netdev *netdev,
     max_rate_s = shash_find_data(details, "max-rate");
 
     min_rate = min_rate_s ? strtoull(min_rate_s, NULL, 10) / 8 : 0;
-    min_rate = MAX(min_rate, 1500);
+    min_rate = MAX(min_rate, 1);
     min_rate = MIN(min_rate, hfsc->max_rate);
 
     max_rate = (max_rate_s
-- 
1.7.4.1




More information about the dev mailing list