[ovs-dev] [PATCH 2/2] hfsc: min-rate tweaks.

Ben Pfaff blp at nicira.com
Tue Mar 15 19:42:32 UTC 2011


On Tue, Mar 15, 2011 at 12:31:32PM -0700, Ethan Jackson wrote:
> A min-rate doesn't make sense on the parent qdisc.  Setting it to
> one seems a bit clearer and will hopefully give the kernel a little
> bit more flexibility.
> 
> There doesn't appear to be any reason to enforce a minimum min-rate
> of 1500Bps on queues. This commit lowers the minimum to 1Bps.  A
> min-rate of 0 is not allowed by hfsc in the kernel.

In HTB, the rate parameter on the parent qdisc is important, as I
understand it.  I assume that you're confident that it doesn't matter
for HFSC.  In that case, this looks fine to me.



More information about the dev mailing list