[ovs-dev] [PATCH 2/2] hfsc: min-rate tweaks.

Ethan Jackson ethan at nicira.com
Tue Mar 15 21:46:06 UTC 2011


There doesn't appear to be any reason to enforce a minimum min-rate
of 1500Bps on queues. This commit lowers the minimum to 1Bps.  A
min-rate of 0 is not allowed by hfsc in the kernel.
---
Thinking it over I don't think it's prudent to make the qdisc changes
originally proposed.  I had misunderstood the documentation.  This is the patch
I plan to send out.

Ethan
---
 lib/netdev-linux.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index baaa1e6..dce7592 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -2973,7 +2973,7 @@ hfsc_parse_class_details__(struct netdev *netdev,
     max_rate_s = shash_find_data(details, "max-rate");
 
     min_rate = min_rate_s ? strtoull(min_rate_s, NULL, 10) / 8 : 0;
-    min_rate = MAX(min_rate, 1500);
+    min_rate = MAX(min_rate, 1);
     min_rate = MIN(min_rate, hfsc->max_rate);
 
     max_rate = (max_rate_s
-- 
1.7.4.1




More information about the dev mailing list