[ovs-dev] [PATCH] ovs-vsctl: Back out garbage collection changes.

Ethan Jackson ethan at nicira.com
Wed Mar 16 22:37:22 UTC 2011


Oops about the commit.

I'll go ahead and add a test case and resubmit.

Ethan

On Wed, Mar 16, 2011 at 3:34 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Mar 16, 2011 at 03:24:22PM -0700, Ethan Jackson wrote:
>> Garbage collection introduced in
>> d3643fc5989f88b1eda701d8aefca0ed3ff9dcdc changed ovs-vsctl so that
>> it would allow the garbage collector to reclaim unused tables
>> instead of manually deleting them itself.  Since garbage collection
>> runs at transaction completion, undeleted tables would hang around
>> and could conflict with future actions in a given transaction.
>> This commit backs out this change.
>
> d3643fc5989f88b1eda701d8aefca0ed3ff9dcdc is the wrong commit number
> for the garbage collection change.  The right commit number is
> c5f341ab193b9126dffef8c77bf8ed35e91290fd.
>
> It would be nice to list a sample ovs-vsctl command in the log message
> that fails without this fix and succeeds with it.  It would be doubly
> nice to add that as a test in tests/ovs-vsctl.at.
>



More information about the dev mailing list