[ovs-dev] [lacp 1/3] vswitchd: Modularize LACP.

Ben Pfaff blp at nicira.com
Fri Mar 18 16:24:49 UTC 2011


On Thu, Mar 17, 2011 at 06:20:18PM -0700, Ethan Jackson wrote:
> This commit pulls LACP code out of the bridge into its own LACP
> module.  Currently this module is only used by the existing bonding
> infrastructure.

The updated version looks good.  I only see one nit left to pick.

In lacp.h, the 'slave' parameter to lacp_send_pdu() is declared as
"const const".  But I don't think that even one "const" should really
be there, because the one function that implements this interface
casts it away immediately.  (If you remove the const, you can remove
that cast.)

Thank you!



More information about the dev mailing list