[ovs-dev] [bridge 01/15] bridge: Always delete the correct interfaces in port_del_ifaces().

Ben Pfaff blp at nicira.com
Mon Mar 21 18:11:47 UTC 2011


Thank you for the review.  I pushed just this one since it is a bug
fix.

On Mon, Mar 21, 2011 at 11:09:04AM -0700, Ethan Jackson wrote:
> Good catch.  Looks Good.
> 
> On Mon, Mar 21, 2011 at 10:59 AM, Ben Pfaff <blp at nicira.com> wrote:
> > This code was checking a name from cfg->interfaces[i] but using the result
> > to decide whether to delete port->ifaces[i]. ?The two arrays aren't
> > necessarily in the same order so this code could delete the wrong iface.
> >
> > Found by inspection. ?This is probably not a common problem in practice
> > because I imagine that deleting an interface from a bond, without deleting
> > the bond itself, is a rare operation. ?The problem would also be
> > intermittent--after a few switch reconfiguration cycles I imagine that
> > the problem would resolve.



More information about the dev mailing list