[ovs-dev] [PATCH] datapath: Add compatibility with sk_buff's vlan_tci before 2.6.33.

Jesse Gross jesse at nicira.com
Wed Mar 23 00:39:29 UTC 2011


On Tue, Mar 22, 2011 at 5:18 PM, Ben Pfaff <blp at nicira.com> wrote:
> +/**
> + * DOC: VLAN tag manipulation.
> + *
> + * &struct sk_buff handling of VLAN tags has evolved over time:
> + *
> + * In 2.6.26 and earlier, VLAN tags were always represented as a raw 802.1Q
> + * header inside the skb data.

This isn't strictly true: vlan acceleration actually existed long
before 2.6.27.  However, on receive the drivers called directly into
the vlan device code and on transmit it was stored in a vlan skb->cb.
Receive is the interesting one for us and we have no chance to get the
tag on these kernels, which is why our code assumes it doesn't exist.

Otherwise looks good.
Acked-by: Jesse Gross <jesse at nicira.com>



More information about the dev mailing list