[ovs-dev] [PATCH] ovs-brcompatd: Delete write-only variable.

Ben Pfaff blp at nicira.com
Fri Mar 25 22:22:36 UTC 2011


---
 vswitchd/ovs-brcompatd.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/vswitchd/ovs-brcompatd.c b/vswitchd/ovs-brcompatd.c
index 4a80289..f874a4d 100644
--- a/vswitchd/ovs-brcompatd.c
+++ b/vswitchd/ovs-brcompatd.c
@@ -233,14 +233,11 @@ static void
 do_get_bridge_parts(const struct ovsrec_bridge *br, struct svec *parts,
                     int vlan, bool break_down_bonds)
 {
-    struct svec ports;
     size_t i, j;
 
-    svec_init(&ports);
     for (i = 0; i < br->n_ports; i++) {
         const struct ovsrec_port *port = br->ports[i];
 
-        svec_add(&ports, port->name);
         if (vlan >= 0) {
             int port_vlan = port->n_tag ? *port->tag : 0;
             if (vlan != port_vlan) {
@@ -256,7 +253,6 @@ do_get_bridge_parts(const struct ovsrec_bridge *br, struct svec *parts,
             svec_add(parts, port->name);
         }
     }
-    svec_destroy(&ports);
 }
 
 /* Add all the interfaces for 'bridge' to 'ifaces', breaking bonded interfaces
-- 
1.7.1




More information about the dev mailing list