[ovs-dev] [sset 0/8] add data type for set of strings

Ben Pfaff blp at nicira.com
Fri Mar 25 22:40:42 UTC 2011


There's an apparent great need for a "set of strings" data type in the Open
vSwitch source tree, since there were many places where either shash or
svec was being used as one.  This series of commits adds a proper data
type for a set of strings and converts all of the places that needed one
over to use it.

svec is not used much anymore after this.  I did leave it in place in a
few spots where it seemed more appropriate than sset.

Ben Pfaff (8):
  Convert shash users that don't use the 'data' value to sset instead.
  dpif: Use sset instead of svec in dpif interface.
  netdev: Use sset instead of svec in netdev interface.
  ovsdb-parser: Use sset instead of svec for detecting unused members.
  ofproto: Change string sets in interface from svec to sset.
  ovs-openflowd: Use sset in place of svec.
  bridge: Use sset in place of svec.
  ovs-brcompatd: Use sset in place of svec.

 lib/dpif-linux.c          |   23 ++++----
 lib/dpif-provider.h       |    2 +-
 lib/dpif.c                |   16 +++---
 lib/dpif.h                |    6 +-
 lib/fatal-signal.c        |   24 +++-----
 lib/netdev-linux.c        |   12 ++--
 lib/netdev-provider.h     |    8 +-
 lib/netdev.c              |   52 ++++++++---------
 lib/netdev.h              |   10 ++--
 lib/ovsdb-parser.c        |   14 ++---
 lib/ovsdb-parser.h        |    6 +-
 lib/svec.c                |   18 +-----
 lib/svec.h                |    3 +-
 ofproto/collectors.c      |   20 ++----
 ofproto/collectors.h      |    7 +-
 ofproto/netflow.c         |    3 +-
 ofproto/netflow.h         |    6 +-
 ofproto/ofproto-sflow.c   |   10 ++--
 ofproto/ofproto.c         |   40 +++++++-----
 ofproto/ofproto.h         |   11 ++--
 ovsdb/ovsdb-server.c      |   34 +++++------
 utilities/ovs-dpctl.c     |   42 ++++++-------
 utilities/ovs-openflowd.c |   86 ++++++++++++++++-----------
 utilities/ovs-vsctl.c     |   31 +++++-----
 vswitchd/bridge.c         |  142 ++++++++++++++++++++++----------------------
 vswitchd/ovs-brcompatd.c  |   54 ++++++++----------
 26 files changed, 329 insertions(+), 351 deletions(-)




More information about the dev mailing list