[ovs-dev] [bug5144 3/5] ovsdb: Raise database corruption log level from warning to error.

Ben Pfaff blp at nicira.com
Mon Mar 28 20:07:54 UTC 2011


If there's database corruption then it indicates that something went wrong,
e.g. the machine was powered-off by power failure.  It's definitely
something that the admin should know about.  This sounds like an error to
me, so use that log level.
---
 ovsdb/file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ovsdb/file.c b/ovsdb/file.c
index 9f0ab28..1425beb 100644
--- a/ovsdb/file.c
+++ b/ovsdb/file.c
@@ -230,7 +230,7 @@ ovsdb_file_open__(const char *file_name,
          * truncated due to power failure etc. and we should use its current
          * contents. */
         char *msg = ovsdb_error_to_string(error);
-        VLOG_WARN("%s", msg);
+        VLOG_ERR("%s", msg);
         free(msg);
 
         ovsdb_error_destroy(error);
-- 
1.7.1




More information about the dev mailing list