[ovs-dev] [bug5144 1/5] ovsdb-types: Fix bug in ovsdb_base_type_is_ref().

[Ethan Jackson]

Is this series urgent?  I can put it at the top of my review queue.

Ethan

On Mon, Mar 28, 2011 at 1:07 PM, Ben Pfaff <blp at nicira.com> wrote:
> This function only worked properly inside OVSDB itself, because that is
> the only place where the 'refTable' member of ovsdb_base_type is set.
> Both inside and outside OVSDB, 'refTableName' is set for reference types,
> so it's better to check for that.
>
> This doesn't fix any existing bug because this function was only used
> inside OVSDB until now.
> ---
>  lib/ovsdb-types.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/ovsdb-types.h b/lib/ovsdb-types.h
> index 6903aa8..e852391 100644
> --- a/lib/ovsdb-types.h
> +++ b/lib/ovsdb-types.h
> @@ -1,4 +1,4 @@
> -/* Copyright (c) 2009, 2010 Nicira Networks
> +/* Copyright (c) 2009, 2010, 2011 Nicira Networks
>  *
>  * Licensed under the Apache License, Version 2.0 (the "License");
>  * you may not use this file except in compliance with the License.
> @@ -174,7 +174,7 @@ ovsdb_atomic_type_is_valid(enum ovsdb_atomic_type atomic_type)
>  static inline bool
>  ovsdb_base_type_is_ref(const struct ovsdb_base_type *base)
>  {
> -    return base->type == OVSDB_TYPE_UUID && base->u.uuid.refTable;
> +    return base->type == OVSDB_TYPE_UUID && base->u.uuid.refTableName;
>  }
>
>  static inline bool
> --
> 1.7.1
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>