[ovs-dev] [PATCH] ovs-vsctl: Remove dead code.

Justin Pettit jpettit at nicira.com
Tue Mar 29 05:05:00 UTC 2011


Looks good to me.

--Justin


On Mar 28, 2011, at 5:48 PM, Ethan Jackson wrote:

> Coverity #10710.
> ---
> utilities/ovs-vsctl.c |    3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
> index 2baab00..0068f64 100644
> --- a/utilities/ovs-vsctl.c
> +++ b/utilities/ovs-vsctl.c
> @@ -2502,9 +2502,6 @@ parse_column_key_value(const char *arg,
>         }
>         *valuep = xstrdup(p + best_len);
>     } else {
> -        if (valuep) {
> -            *valuep = NULL;
> -        }
>         if (*p != '\0') {
>             error = xasprintf("%s: trailing garbage \"%s\" in argument",
>                               arg, p);
> -- 
> 1.7.4.1
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev




More information about the dev mailing list