[ovs-dev] [restart 1/3] daemon: Write "already running" message to log also.

Justin Pettit jpettit at nicira.com
Tue Mar 29 05:18:28 UTC 2011


On Mar 28, 2011, at 4:24 PM, Ben Pfaff wrote:

> @@ -141,7 +141,9 @@ def die_if_already_running():
>     ignore_existing_pidfile() has been called, terminate the program."""
>     if _already_running():
>         if not _overwrite_pidfile:
> -            sys.stderr.write("%s: already running\n" % get_pidfile())
> +            msg = "%s: already running as pid %d" % (_pidfile, pid)
> +            logging.error(msg)
> +            sys.stderr.write("%s\n" % msg)

Is "pid" declared somewhere?  I didn't see it, but I may have missed it...

Otherwise, looks good.

--Justin





More information about the dev mailing list