[ovs-dev] [PATCH] ovs-vsctl: Remove dead assignment.

Ethan Jackson ethan at nicira.com
Tue Mar 29 17:59:59 UTC 2011


Noticed this last night while playing around with the clang static
analyzer.
---
 utilities/ovs-vsctl.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index 0068f64..b8c6d30 100644
--- a/utilities/ovs-vsctl.c
+++ b/utilities/ovs-vsctl.c
@@ -2799,11 +2799,10 @@ cmd_list(struct vsctl_context *ctx)
         }
     } else {
         const struct ovsdb_idl_row *row;
-        bool first;
 
-        for (row = ovsdb_idl_first_row(ctx->idl, table->class), first = true;
+        for (row = ovsdb_idl_first_row(ctx->idl, table->class);
              row != NULL;
-             row = ovsdb_idl_next_row(row), first = false) {
+             row = ovsdb_idl_next_row(row)) {
             list_record(row, columns, n_columns, out);
         }
     }
-- 
1.7.4.1




More information about the dev mailing list