[ovs-dev] [PATCH] mac-learning: Fix mac_entry_is_grat_arp_locked().

[Ben Pfaff]

On Wed, Mar 30, 2011 at 01:55:53PM -0700, Ethan Jackson wrote:
> Nice catch, how did you notice this?

Testing the bonding library, the buggy version caused an assertion
failure in mac_learning_lookup() whenever a gratuitous ARP appeared,
because update_learning_table() would skip calling
mac_learning_changed() for the new entry.

Gratuitous ARPs are more common while testing bonding, since the
bonding code sends them out itself.

> Incidentally, I've been thinking about if it's a good idea to
> implement a timer library which may prevent errors like this in the
> future.

I think it's a good idea if it makes code more obviously correct and
doesn't add significant overhead.  What do you have in mind?