[ovs-dev] [PATCH] cfm: Fix appctl negative report.

Ethan Jackson ethan at nicira.com
Thu Mar 31 23:17:02 UTC 2011


I noticed this while testing the timer changes. It was introduced back
when I implemented the extra cfm debugging stuff.

On Thu, Mar 31, 2011 at 4:14 PM, Ethan Jackson <ethan at nicira.com> wrote:
> When the cfm module has never received a bad CCM message, it would
> report a negative time.
> ---
>  lib/cfm.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/cfm.c b/lib/cfm.c
> index 4e5117d..fc7486e 100644
> --- a/lib/cfm.c
> +++ b/lib/cfm.c
> @@ -399,11 +399,14 @@ cfm_dump_ds(const struct cfm *cfm, struct ds *ds)
>
>     ds_put_format(ds, "\tinterval: %dms\n", cfmi->ccm_interval_ms);
>     ds_put_format(ds, "\ttime since CCM tx: %lldms\n", now - cfmi->ccm_sent);
> -    ds_put_format(ds, "\ttime since bad CCM rx: %lldms\n",
> -                  now - cfmi->x_recv_time);
>     ds_put_format(ds, "\ttime since fault check: %lldms\n",
>                   now - cfmi->fault_check);
>
> +    if (cfmi->x_recv_time != LLONG_MIN) {
> +        ds_put_format(ds, "\ttime since bad CCM rx: %lldms\n",
> +                      now - cfmi->x_recv_time);
> +    }
> +
>     ds_put_cstr(ds, "\n");
>     HMAP_FOR_EACH (rmp, node, &cfm->remote_mps) {
>         ds_put_format(ds, "Remote MPID %"PRIu16": %s\n", rmp->mpid,
> --
> 1.7.4.2
>
>



More information about the dev mailing list