[ovs-dev] [warnings 0/8] Fix up log messages and update tests to match
Ben Pfaff
blp at nicira.com
Mon May 2 19:57:56 UTC 2011
I made a pass through the "tests" directory, looking for tests that
ignore stdout or stderr output. It's generally not a good idea to do
that because it means that changes to output can easily be missed.
As I did so, I found a few issues to fix, so this series fixes those
up too.
Ben Pfaff (8):
tests: Check test output more carefully.
lockfile: Don't warn if successful lock takes a little time.
ofp-util: Don't warn for different forms of nw_{src,dst} wildcards.
ofp-util: Simplify OpenFlow 1.0 ofp_match normalization.
ofp-util: Revise OpenFlow 1.0 ofp_match normalization.
netdev-linux: Only call set_nonblocking() if socket creation
succeeds.
netdev-linux: Open AF_PACKET socket only when it is needed.
tests: Check ovs-openflowd log output instead of ignoring it.
lib/lockfile.c | 11 +---
lib/netdev-linux.c | 38 ++++++++---
lib/ofp-util.c | 162 ++++++++++++-----------------------------------
lib/ofp-util.h | 1 -
tests/autopath.at | 4 +-
tests/daemon-py.at | 10 ++--
tests/daemon.at | 10 ++--
tests/jsonrpc-py.at | 6 +-
tests/jsonrpc.at | 6 +-
tests/library.at | 21 ++++---
tests/ofp-print.at | 16 ++++-
tests/ofproto-macros.at | 8 ++-
tests/ovs-ofctl.at | 13 +----
tests/ovsdb-log.at | 2 +-
tests/ovsdb-server.at | 12 ++--
tests/test-strtok_r.c | 2 +-
16 files changed, 130 insertions(+), 192 deletions(-)
--
1.7.4.4
More information about the dev
mailing list