[ovs-dev] [next 06/35] bridge: Avoid extra iteration through all "struct iface"s.

Ethan Jackson ethan at nicira.com
Mon May 2 18:06:07 UTC 2011


>             LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
>                 iface_update_qos(iface, port->cfg->qos);
> +                netdev_set_policing(iface->netdev,
> +                                    iface->cfg->ingress_policing_rate,
> +                                    iface->cfg->ingress_policing_burst);
> +                if (iface->dp_ifidx != ODPP_LOCAL
> +                    && !strcmp(iface->type, "internal")) {
> +                    iface_set_mac(iface);

I think it makes more sense to always call iface_set_mac() rather than
checking.  It already has logic for dealing with the case where it's
ODPP_LOCAL or has type internal.

Ethan



More information about the dev mailing list