[ovs-dev] [PATCH] ofproto: Resubmit statistics improperly account during failover.

Ethan Jackson ethan at nicira.com
Tue May 3 20:40:04 UTC 2011

>    ofproto tracks facet stats that have already been accounted into
>    OpenFlow rule using dp_packet_count and dp_byte_count.  When we
>    query the database, only packets or bytes in excess of those
>    values should be considered.  The 'stat's parameter to
>    facet_update_stats() should only be passed those values in excess.
>    Some of the callers, however, were not doing this:
>    facet_revalidate() failed to subtract already-accounted packets
>    and bytes, and so did facet_uninstall().


> If I'm right about that, then your patch is correct but insufficient:
> we should make a similar change to facet_uninstall(), perhaps
> factoring out the common code into a function.

Good catch.  It would be extremely edge case-ish for this to actually
be a noticeable bug, but it's a bug nonetheless.

I'll revise the patch and resend it.


More information about the dev mailing list