[ovs-dev] [PATCH] ofproto: Resubmit statistics improperly account during failover.

Ethan Jackson ethan at nicira.com
Wed May 4 00:53:22 UTC 2011


> The only potential issue I see here is with logging on error paths.
> If dpif_flow_put() or dpif_flow_del() returns an error then they will
> zero their stats arguments, which will then almost certainly cause an
> error to be logged in facet_reset_dp_stats().  That's going to be a
> bit confusing, although it won't cause any actual problems.  If you
> see a nice way to avoid it, though, I'd think about it.

I think I will just drop the log message.  I can't really imagine it
ever be helpful in finding a problem given how vague it is, and how
many ways it could be triggered.

Ethan



More information about the dev mailing list