[ovs-dev] [next 16/35] bridge: Get rid of bridge_get_all_ifaces(), bridge_fetch_dp_ifaces().

Ben Pfaff blp at nicira.com
Wed May 4 17:18:16 UTC 2011


On Mon, May 02, 2011 at 04:31:15PM -0700, Ethan Jackson wrote:
> Looks Good.  Couple of minor things.
> 
> > + ? ? ? ? ? ?error = ofproto_port_del(br->ofproto, ofproto_port.ofp_port);
> > + ? ? ? ? ? ?if (error) {
> > + ? ? ? ? ? ? ? ?VLOG_WARN("bridge %s: failed to remove %s interface "
> > + ? ? ? ? ? ? ? ? ? ? ? ? ?"(%s)", br->name, name,
> > + ? ? ? ? ? ? ? ? ? ? ? ? ?strerror(error));
> 
> This is indented a bit strangely.  the (%s) can join the string on the
> line above it, and the strerror can join the previous line as well.

Thanks, I fixed this up.

> > + ? ? ? ? ? ?/* Add bond fake iface if necesssary. */
> This should be spelled "necessary".

Thanks, I fixed this too now.



More information about the dev mailing list