[ovs-dev] [PATCH] ofp-util: Fix validation of OFPAT_SET_VLAN_PCP actions.

Ben Pfaff blp at nicira.com
Wed May 4 22:47:32 UTC 2011


Found by sparse.
---
 lib/ofp-util.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 5aa2b82..ddac772 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -1922,7 +1922,7 @@ check_action(const union ofp_action *a, unsigned int len,
         if (error) {
             return error;
         }
-        if (a->vlan_vid.vlan_vid & ~7) {
+        if (a->vlan_pcp.vlan_pcp & ~7) {
             return ofp_mkerr(OFPET_BAD_ACTION, OFPBAC_BAD_ARGUMENT);
         }
         return 0;
-- 
1.7.4.4




More information about the dev mailing list