[ovs-dev] [PATCH 1/2] xenserver: Use xe-switch-network-stack in RPM spec file.

Justin Pettit jpettit at nicira.com
Thu May 5 07:51:17 UTC 2011

On May 4, 2011, at 9:32 AM, Ben Pfaff wrote:

> On Tue, May 03, 2011 at 11:23:04PM -0700, Justin Pettit wrote:
>> The proper way to switch the networking back-end is to use the
>> "xe-switch-network-stack" command rather than directly modifying
>> "/etc/xensource/network.conf".  Use that method in the spec file.
> Looks OK to me.
> I'm not sure that the scriptlet needs to print a message any longer,
> because xe-switch-network-stack already prints:
> 	You *MUST* now reboot your system
> to stderr, as well as a bunch of progress information to stdout.

I had modified some of the message to remove the redundant part of a reboot being required.  However, I guess there's not much point in explaining that networking may be affected by not rebooting when such an emphatic statement is made.  I removed the extra text and will push the series when network connectivity returns.

Thanks for the reviews.


More information about the dev mailing list