[ovs-dev] [PATCH 2/3] bond: Create new "bond-stable-id".

Ben Pfaff blp at nicira.com
Fri May 6 20:34:49 UTC 2011


On Fri, May 06, 2011 at 01:02:10PM -0700, Ethan Jackson wrote:
> Stable bonding mode needs an ID to guarantee consistent slave
> selection decisions across ovs-vswitchd instances.  Before this
> patch, we used the lacp-port-id for this purpose.  However, LACP
> places restrictions on how lacp-port-ids can be allocated which may
> be inconvenient.  This patch creates a special purpose
> bond-stable-id other_config setting which allows users to tweak
> this value directly.

This documents the default stable ID to be the OpenFlow port number
and uses dp_ifidx for it.  dp_ifidx is usually the OpenFlow port
number but not for OFPP_LOCAL.  It wouldn't make sense to add
OFPP_LOCAL to a bond but I'd still prefer to see dp_ifidx passed
through odp_port_to_ofp_port() if just for the documentation value.

In the documentation:

   Please capitalize "OpenFlow".

   You wrote <code>bond-stable-ids</code> at one point, but the key is
   <code>bond-stable-id</code> (without the s) and this might confuse
   someone.

   This adds documentation for lacp-force-aggregatable but doesn't add
   an implementation.

   I'd document "bond-stable-id" as not nonzero but positive.

Thanks,

Ben.



More information about the dev mailing list