[ovs-dev] [next 33/35] ofproto: Improve abstraction by using OpenFlow port numbers in interface.

Ethan Jackson ethan at nicira.com
Sat May 7 00:36:09 UTC 2011

I like this patch, it always seemed strange to me that the bridge
cared about dp_ifidxes.

One thing I've been wondering about in the past couple of patches I've
reviewed.  It seems a bit strange to me that "ofport" is indexed based
on odp_port not ofp_port.  It' makes the ofproto module a bit awkward
in places because you always have to convert in calls to get_port().
I'm not sure that this patch is the place to change it, or if it
should be changed.  Just thought I would through that out there.

> -    /* Obtain the correct "dp_ifidx"es from ofproto. */
> +    /* Obtain the correct "ofp_port"es from ofproto. */
"es" => "s"

Looks Good.

More information about the dev mailing list