[ovs-dev] [branch-1.1 4/6] ofp-util: Fix validation of OFPAT_SET_VLAN_PCP actions.

Ben Pfaff blp at nicira.com
Tue May 10 18:08:17 UTC 2011


Found by sparse.
---
 lib/ofp-util.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 5c95270..d39b0bc 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -2053,7 +2053,7 @@ check_action(const union ofp_action *a, unsigned int len,
         if (error) {
             return error;
         }
-        if (a->vlan_vid.vlan_vid & ~7) {
+        if (a->vlan_pcp.vlan_pcp & ~7) {
             return ofp_mkerr(OFPET_BAD_ACTION, OFPBAC_BAD_ARGUMENT);
         }
         return 0;
-- 
1.7.4.4




More information about the dev mailing list