[ovs-dev] [PATCH 2/2] xenserver: spec file uses kernel_version and kernel_suffix from cmdline

Sajjad Lateef slateef at nicira.com
Tue May 10 22:55:45 UTC 2011

On Tue, May 10, 2011 at 3:53 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, May 10, 2011 at 03:43:35PM -0700, Sajjad Lateef wrote:
>> Citrix build Oxford CSP kernel does not follow earlier convention of kernel name suffix
>> being used as the suffix of the kernel version.
>> In conjunction with this change, the build process will be modified to use rpm
>> to query the installed kernel.*devel package for its Version, Release and Name
>> The build process will them invoke rpmbuild with the values on the command line.
>> The changes to the build process are documented in INSTALL.XenServer
>> Updated INSTALL.XenServer to reflect this change.
>> With this change, the spec file is modified to use the command line arguments
>> of kernel_version and kernel_suffix and use these to name the openvswitch-modules
>> package and its dependencies.
>> Signed-off-by: Sajjad Lateef <slateef at nicira.com>
> This should also go on the "master" branch, right?  Presumably it
> works with both the "old-style" and new Oxford CSP style kernel
> naming.  I'm happy to cherry-pick it over to there once you've pushed
> this to the new "oxford" branch, or you can do it yourself.

I was planning to cherry-pick it over soon.

I have tested with both old style spec file (where the the new variables
are simply not used) and the new style spec file (where it was successful).

> As long as you've tested it and found that it works, it's fine with
> me.  Thank you!

Thank you for the review.


Sajjad Lateef
slateef at nicira.com

More information about the dev mailing list